Codecov Report

Attention: Patch coverage is 89.09091% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.56%. Comparing base (0d6e6bf) to head (0716a03).
Report is 12 commits behind head on main.

❗ Current head 0716a03 differs from pull request most recent head b4bcc9f

Please upload reports for the commit b4bcc9f to get more accurate results.

@@           Coverage Diff           @@
##             main   #10372   +/-   ##
=======================================
  Coverage   92.56%   92.56%           
=======================================
  Files         387      387           
  Lines       18254    18297   +43     
=======================================
+ Hits        16896    16937   +41     
- Misses       1014     1015    +1     
- Partials      344      345    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I am okay with breaking API in one go, but the breaking change should appear in the API changelog.

Thanks, I'll add a changelog - just wanted to agree on the direction before going further with it.

I am not sure if there is any overlap with open-telemetry/oteps/pull/259 (I guess not in terms of the metric names, but possibly on the namespaces?). Is there a chance we would have to change these after that OTEP is finalized?

I think there is overlap and if the otep is accepted we will need to make quite a few changes. However, my understanding of the proposal is that all of the counts we currently have for processors, as well as these "inserted" counts would be relevant, though they would be grouped with others into new metrics. I think regardless of this PR we may end up deprecating the current metrics in favor of a new set, but both could coexist for a while.